On Tue, Jul 14, 2020 at 10:48:14PM +0530, Naresh Kamboju wrote:
> arm64 build failed on 5.4
>
> make -sk KBUILD_BUILD_USER=TuxBuild -C/linux -j16 ARCH=arm64
> CROSS_COMPILE=aarch64-linux-gnu- HOSTCC=gcc CC="sccache
> aarch64-linux-gnu-gcc" O=build Image
> #
> ../drivers/clocksource/arm_arch_timer.c:484:4: error: ‘const struct
> arch_timer_erratum_workaround’ has no member named
> ‘disable_compat_vdso’
> 484 | .disable_compat_vdso = true,
> | ^~~~~~~~~~~~~~~~~~~
> ../drivers/clocksource/arm_arch_timer.c:484:26: warning:
> initialization of ‘u32 (*)(void)’ {aka ‘unsigned int (*)(void)’} from
> ‘int’ makes pointer from integer without a cast [-Wint-conversion]
> 484 | .disable_compat_vdso = true,
> | ^~~~
> ../drivers/clocksource/arm_arch_timer.c:484:26: note: (near
> initialization for ‘ool_workarounds[5].read_cntp_tval_el0’)
>
> Could be this patch,
> arm64: arch_timer: Disable the compat vdso for cores affected by
> ARM64_WORKAROUND_1418040
> commit 4b661d6133c5d3a7c9aca0b4ee5a78c7766eff3f upstream.
>
> ARM64_WORKAROUND_1418040 requires that AArch32 EL0 accesses to
> the virtual counter register are trapped and emulated by the kernel.
> This makes the vdso pretty pointless, and in some cases livelock
> prone.
>
> Provide a workaround entry that limits the vdso to 64bit tasks.
>
> Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
> Acked-by: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Link: https://lore.kernel.org/r/20200706163802.1836732-4-maz@xxxxxxxxxx
> Signed-off-by: Will Deacon <will@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
>
> ref:
> https://gitlab.com/Linaro/lkft/kernel-runs/-/jobs/638094006
Thanks, I've now dropped this patch.
greg k-h
