On Mon, 15 Jun 2020 12:24:00 -0700 Joe Perches <joe@xxxxxxxxxxx> wrote: > > Hmm, shouldn't the above have the upside-down xmas tree format? > > > > struct xbc_node *leaf, *vnode; > > char *key, *end = dst + size; > > const char *val; > > char q; > > int ret = 0; > > Please don't infect kernel sources with that style oddity. What do you mean? It's already "infected" all over the kernel, (has been for years!) and I kinda like it. It makes reading variables much easier on the eyes, and as I get older, that means a lot more ;-) -- Steve