On Mon, 2020-06-15 at 15:11 -0400, Steven Rostedt wrote: > On Sat, 13 Jun 2020 00:23:18 +0900 > Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote: [] > > diff --git a/fs/proc/bootconfig.c b/fs/proc/bootconfig.c [] > > @@ -27,6 +27,7 @@ static int __init copy_xbc_key_value_list(char *dst, size_t size) > > { > > struct xbc_node *leaf, *vnode; > > const char *val; > > + char q; > > char *key, *end = dst + size; > > int ret = 0; > > Hmm, shouldn't the above have the upside-down xmas tree format? > > struct xbc_node *leaf, *vnode; > char *key, *end = dst + size; > const char *val; > char q; > int ret = 0; Please don't infect kernel sources with that style oddity.