Re: Patch "crypto: talitos - fix ECB and CBC algs ivsize" has been added to the 4.9-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Le 11/06/2020 à 13:21, gregkh@xxxxxxxxxxxxxxxxxxx a écrit :

This is a note to let you know that I've just added the patch titled

     crypto: talitos - fix ECB and CBC algs ivsize

to the 4.9-stable tree which can be found at:
     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
      crypto-talitos-fix-ecb-and-cbc-algs-ivsize.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.

As far as I can see, the faulty commit e1de42fdfc6a ("crypto: talitos - fix ECB algs ivsize") only removed .ivsize = AES_BLOCK_SIZE at a wrong place.

The other changes (removal of .ivsize = DES_BLOCK_SIZE and .ivsize = DES3_EDE_BLOCK_SIZE) are not from the faulty patch.

Christophe



 From cantona@xxxxxxxxxxx  Thu Jun 11 12:53:25 2020
From: Su Kang Yin <cantona@xxxxxxxxxxx>
Date: Thu, 11 Jun 2020 18:07:45 +0800
Subject: crypto: talitos - fix ECB and CBC algs ivsize
To: gregkh@xxxxxxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, christophe.leroy@xxxxxx
Cc: Su Kang Yin <cantona@xxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
Message-ID: <20200611100745.6513-1-cantona@xxxxxxxxxxx>

From: Su Kang Yin <cantona@xxxxxxxxxxx>

Patch for 4.9 upstream:

commit e1de42fdfc6a ("crypto: talitos - fix ECB algs ivsize")
wrongly modified CBC algs ivsize instead of ECB aggs ivsize.

This restore the CBC algs original ivsize of removes ECB's ones.

Signed-off-by: Su Kang Yin <cantona@xxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
  drivers/crypto/talitos.c |    4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c
@@ -2636,7 +2636,6 @@ static struct talitos_alg_template drive
  			.cra_ablkcipher = {
  				.min_keysize = AES_MIN_KEY_SIZE,
  				.max_keysize = AES_MAX_KEY_SIZE,
-				.ivsize = AES_BLOCK_SIZE,
  			}
  		},
  		.desc_hdr_template = DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
@@ -2670,6 +2669,7 @@ static struct talitos_alg_template drive
  			.cra_ablkcipher = {
  				.min_keysize = AES_MIN_KEY_SIZE,
  				.max_keysize = AES_MAX_KEY_SIZE,
+				.ivsize = AES_BLOCK_SIZE,
  				.setkey = ablkcipher_aes_setkey,
  			}
  		},
@@ -2687,7 +2687,6 @@ static struct talitos_alg_template drive
  			.cra_ablkcipher = {
  				.min_keysize = DES_KEY_SIZE,
  				.max_keysize = DES_KEY_SIZE,
-				.ivsize = DES_BLOCK_SIZE,
  			}
  		},
  		.desc_hdr_template = DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |
@@ -2720,7 +2719,6 @@ static struct talitos_alg_template drive
  			.cra_ablkcipher = {
  				.min_keysize = DES3_EDE_KEY_SIZE,
  				.max_keysize = DES3_EDE_KEY_SIZE,
-				.ivsize = DES3_EDE_BLOCK_SIZE,
  			}
  		},
  		.desc_hdr_template = DESC_HDR_TYPE_COMMON_NONSNOOP_NO_AFEU |


Patches currently in stable-queue which might be from cantona@xxxxxxxxxxx are

queue-4.9/crypto-talitos-fix-ecb-and-cbc-algs-ivsize.patch




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux