Re: [linux-stable-rc:linux-5.4.y 2150/5369] drivers/gpu/drm/panfrost/panfrost_job.c:279:31: warning: variable 'bo' set but not used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28/05/2020 08:17, kbuild test robot wrote:
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
head:   e0d81ce760044efd3f26004aa32821c34968512a
commit: 3e041c27b9909704a54bc673f9110391e740f583 [2150/5369] drm/panfrost: Add the panfrost_gem_mapping concept
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
         chmod +x ~/bin/make.cross
         git checkout 3e041c27b9909704a54bc673f9110391e740f583
         # save the attached .config to linux build tree
         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/gpu/drm/panfrost/panfrost_job.c: In function 'panfrost_job_cleanup':
drivers/gpu/drm/panfrost/panfrost_job.c:279:31: warning: variable 'bo' set but not used [-Wunused-but-set-variable]
279 |   struct panfrost_gem_object *bo;
|                               ^~

FYI: This was fixed upstream in fe154a242233 ("drm/panfrost: Remove set but not used variable 'bo'")

Steve

vim +/bo +279 drivers/gpu/drm/panfrost/panfrost_job.c

    252	
    253	static void panfrost_job_cleanup(struct kref *ref)
    254	{
    255		struct panfrost_job *job = container_of(ref, struct panfrost_job,
    256							refcount);
    257		unsigned int i;
    258	
    259		if (job->in_fences) {
    260			for (i = 0; i < job->in_fence_count; i++)
    261				dma_fence_put(job->in_fences[i]);
    262			kvfree(job->in_fences);
    263		}
    264		if (job->implicit_fences) {
    265			for (i = 0; i < job->bo_count; i++)
    266				dma_fence_put(job->implicit_fences[i]);
    267			kvfree(job->implicit_fences);
    268		}
    269		dma_fence_put(job->done_fence);
    270		dma_fence_put(job->render_done_fence);
    271	
    272		if (job->mappings) {
    273			for (i = 0; i < job->bo_count; i++)
    274				panfrost_gem_mapping_put(job->mappings[i]);
    275			kvfree(job->mappings);
    276		}
    277	
    278		if (job->bos) {
  > 279			struct panfrost_gem_object *bo;
    280	
    281			for (i = 0; i < job->bo_count; i++) {
    282				bo = to_panfrost_bo(job->bos[i]);
    283				drm_gem_object_put_unlocked(job->bos[i]);
    284			}
    285	
    286			kvfree(job->bos);
    287		}
    288	
    289		kfree(job);
    290	}
    291	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux