> From: Dan Williams > > Sent: 20 May 2020 16:26 > ... > > > > +#ifdef CONFIG_ARCH_HAS_COPY_MC > > > > +extern unsigned long __must_check > > > > > > We try not to add extern in headers anymore. > > > > Ok, I was doing the copy-pasta dance, but I'll remove this. > > It is data not code, it needs the extern to not be 'common'. > OTOH what is a global variable being used for? Aaarg not enough context... - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)