RE: [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: RE: [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()
From: David Laight <David.Laight@xxxxxxxxxx>
Date: Wed, 20 May 2020 15:33:27 +0000
Accept-language: en-GB, en-US
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, "X86 ML" <x86@xxxxxxxxxx>, stable <stable@xxxxxxxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, "Linus Torvalds" <torvalds@xxxxxxxxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, linux-nvdimm <linux-nvdimm@xxxxxxxxxxxx>
In-reply-to: <CAPcyv4igM-jK6OkPzd91ur_fNCaUxwbWTHhwWsWe-PJNjZdWGw@mail.gmail.com>
Thread-index: AQHWLrr3OGthQXUtsU6REk+fDuiGdKixGiVw
Thread-topic: [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()

From: Dan Williams
> Sent: 20 May 2020 16:26
...
> > > +#ifdef CONFIG_ARCH_HAS_COPY_MC
> > > +extern unsigned long __must_check
> >
> > We try not to add extern in headers anymore.
> 
> Ok, I was doing the copy-pasta dance, but I'll remove this.

It is data not code, it needs the extern to not be 'common'.
OTOH what is a global variable being used for?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

Follow-Ups:
- RE: [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()
  - From: David Laight

References:
- [PATCH v3 0/2] Renovate memcpy_mcsafe with copy_mc_to_{user, kernel}
  - From: Dan Williams
- [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()
  - From: Dan Williams
- Re: [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()
  - From: Michael Ellerman
- Re: [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()
  - From: Dan Williams

Prev by Date: Re: [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()
Next by Date: RE: [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()
Previous by thread: Re: [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()
Next by thread: RE: [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Development Newbies] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite Hiking] [Linux Kernel] [Linux SCSI]