Re: WTF: patch "[PATCH] powerpc/powernv: Refactor PHB diag-data dump" was seriously submitted to be applied to the 3.13-stable tree?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2014-03-03 at 19:47 -0800, Greg KH wrote:

> Error logging?  This is "KERN_INFO" level, that's not an error.  Or at
> least userspace shouldn't be treating it as such.
> 
> And if you are relying on the kernel log for errors, something is wrong,
> why not use something else?
> 
> > This patch has the effect of reducing the output size significantly and
> > improves the situation.
> 
> It's changing printks, how does that affect the operation of the
> machine?
> 
> > I decided to send it to stable because I want it back into distros, the
> > risk is negligible and the benefit significant.
> 
> I don't understand the benifit, as this is just informational messages.
> What relies on this?

Me among others when people on the field hit EEH errors and have to send
me the logs so I can understand why the HW went wrong. In the long run
we will replace the raw register dump with something a bit better
"interpreted" (ie. DMA error at address xxxx, that sort of thing) but
we don't have a decoder ring yet, so all we have is the raw register
dump. The old way of printing it was simply too verbose to be practical.

This is not a huge deal, if you prefer leaving this out, then do, but
it would have made my life easier :-)

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]