On Mon, Nov 25, 2019 at 08:30:48AM -0500, Sasha Levin wrote:
> On Sat, Nov 23, 2019 at 08:22:44PM +0100, Willy Tarreau wrote:
> > On Sat, Nov 23, 2019 at 01:08:03PM -0600, Bob Funk wrote:
> > > For the record, the patch that Willy offered does fix the issue on my
> > > affected
> > > system. That might be a better choice than my request to revert as per the
> > > original email.
> >
> > Greg, FWIW I did nothing more than a regular backport so that you can take
> > it as-is. I think you dropped it from 4.4 because it did not apply well
> > and was not worth the hassle, but given that it fixes a regression caused
> > by another backport I think it makes sense to take it, at least so that
> > some users do not stop updating. The fix was only merged into 4.19, not
> > 4.4/4.9/4.14.
> >
> > The backports for 4.9 and 4.14 are easy to do, if you're willing to take
> > the patches I can do them as well, just let me know.
>
> Let's try something like this:
>
> For 4.14 and 4.9 I'll also grab db2582afa744 ("platform/x86:
> asus-nb-wmi: Support ALS on the Zenbook UX430UQ") which makes 401fee819
> apply cleanly.
>
> For 4.4, I'll grab this long list:
>
> 92a505e8055f ("platform/x86: asus-wmi: add SERIO_I8042 dependency")
> db2582afa744 ("platform/x86: asus-nb-wmi: Support ALS on the Zenbook UX430UQ")
> 71f38c11cdb8 ("platform/x86: asus-wmi: Set specified XUSB2PR value for X550LB")
> 999d4376c628 ("platform/x86: asus-wmi: fix asus ux303ub brightness issue")
> a961a285b479 ("asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UF")
> a977e59c0c67 ("asus-wmi: Create quirk for airplane_mode LED")
> 6b7ff2af5286 ("asus-wmi: Add quirk_no_rfkill for the Asus Z550MA")
> 02db9ff7af18 ("asus-wmi: Add quirk_no_rfkill for the Asus U303LB")
> 2d735244b798 ("asus-wmi: Add quirk_no_rfkill for the Asus N552VW")
> b5643539b825 ("platform/x86: asus-wmi: Filter buggy scan codes on ASUS Q500A")
> 7c1c184bb571 ("platform/x86: asus-wmi: try to set als by default")
> aca234f63788 ("asus-wmi: provide access to ALS control")
>
> Which looks scary, but it's all quirks for laptops folks are actually
> using with this kernel. Then 401fee819 also applies cleanly on 4.4.
Ah the joy of dealing with stable branches :-) I agree that all of them
are sufficiently small and isolated to be easy to deal with, and if they
can avoid bug reports that's always a bonus.
Willy
