On 9/19/19 10:55 AM, Kees Cook wrote:
On Thu, Sep 19, 2019 at 01:42:51PM +0300, Dmitry V. Levin wrote:
On Wed, Sep 18, 2019 at 10:33:09AM -0700, Kees Cook wrote:
This is actually fixed in -next already (and, yes, with the Fixes line
Tyler has mentioned):
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=next&id=69b2d3c5924273a0ae968d3818210fc57a1b9d07
Excuse me, does it mean that you expect each selftest to be self-hosted?
I was (and still is) under impression that selftests should be built
with headers installed from the tree. Is it the case, or is it not?
As you know (but to give others some context) there is a long-standing
bug in the selftest build environment that causes these problems (it
isn't including the uAPI headers) which you'd proposed to be fixed
recently[1]. Did that ever get sent as a "real" patch? I don't see it
in Shuah's tree; can you send it to Shuah?
But even with that fixed, since the seccomp selftest has a history of
being built stand-alone, I've continued to take these kinds of fixes.
-Kees
[1] https://lore.kernel.org/lkml/20190805094719.GA1693@xxxxxxxxxxxx/
It has been sent to kselftest list yesterday. I will pull this in for
my next update.
thanks,
-- Shuah
