On Mon, 6 Jan 2014, Greg KH wrote: > Date: Mon, 6 Jan 2014 09:00:36 -0800 > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> > To: Lukas Czerner <lczerner@xxxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] ext4: fix FITRIM in no journal mode > > On Mon, Jan 06, 2014 at 05:29:37PM +0100, Lukas Czerner wrote: > > Upstream commit: 8f9ff189205a6817aee5a1f996f876541f86e07c > > Stable version: 3.12.y > > > > When using FITRIM ioctl on a file system without journal it will > > only trim the block group once, no matter how many times you invoke > > FITRIM ioctl and how many block you release from the block group. > > > > It is because we only clear EXT4_GROUP_INFO_WAS_TRIMMED_BIT in journal > > callback. Fix this by clearing the bit in no journal mode as well. > > > > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx> > > Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx> > > Reported-by: Jorge Fábregas <jorge.fabregas@xxxxxxxxx> > > --- > > fs/ext4/mballoc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Thanks, I've also applied this to 3.10-stable as it seems applicable > there as well, right? Right, thanks! -Lukas > > greg k-h >