On Thu, Dec 26, 2013 at 11:08:02AM +0900, Nobuhiro Iwamatsu wrote: > Hi, > > This was applied by 84ed8a99058e61567f495cc43118344261641c5f. > > Best regards, > Nobuhiro Thank you, I'm queuing it for the 3.5 and 3.11 kernels. Cheers, -- Luis > > (2013/12/19 11:46), Greg KH wrote: > >On Thu, Dec 19, 2013 at 10:40:19AM +0900, Nobuhiro Iwamatsu wrote: > >>From: Geert Uytterhoeven<geert@xxxxxxxxxxxxxx> > >> > >>E.g. landisk_defconfig, which has CONFIG_NTFS_FS=m: > >> > >>ERROR: "__ashrdi3" [fs/ntfs/ntfs.ko] undefined! > >> > >>For "lib-y", if no symbols in a compilation unit are referenced by other > >>units, the compilation unit will not be included in vmlinux. > >>This breaks modules that do reference those symbols. > >> > >>Use "obj-y" instead to fix this. > >> > >>http://kisskb.ellerman.id.au/kisskb/buildresult/8838077/ > >> > >>This doesn't fix all cases. There are others, e.g. udivsi3. > >>This is also not limited to sh, many architectures handle this in the same > >>way. > >> > >>A simple solution is to unconditionally include all helper functions. > >>A more complex solution is to make the choice of "lib-y" or "obj-y" depend > >>on CONFIG_MODULES: > >> obj-$(CONFIG_MODULES) += ... > >> lib-y($CONFIG_MODULES) += ... > >> > >>Signed-off-by: Geert Uytterhoeven<geert@xxxxxxxxxxxxxx> > >>Cc: Paul Mundt<lethal@xxxxxxxxxxxx> > >>Tested-by: Nobuhiro Iwamatsu<nobuhiro.iwamatsu.yj@xxxxxxxxxxx> > >>Reviewed-by: Nobuhiro Iwamatsu<nobuhiro.iwamatsu.yj@xxxxxxxxxxx> > >>Signed-off-by: Andrew Morton<akpm@xxxxxxxxxxxxxxxxxxxx> > >>--- > > > >Same here, what id, and what tree? > > -- > To unsubscribe from this list: send the line "unsubscribe stable" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html