Re: [v5] x86/mm/KASLR: Fix the size of vmemmap section

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/12/19 at 09:19pm, Baoquan He wrote:
> On 06/12/19 at 02:48pm, Sedat Dilek wrote:
> > On Wed, Jun 12, 2019 at 12:15 PM Baoquan He <bhe@xxxxxxxxxx> wrote:
> > >
> > > On 06/04/19 at 01:46pm, Sedat Dilek wrote:
> > > > [ CC me I am not subscribed to linux-stable ML ]
> > > > [ CC Greg and Sasha ]
> > > >
> > > > Hi Baoquan,
> > > >
> > > > that should be s/Fiexes/Fixes for the "Fixes tag".
> > > >
> > > > OLD: Fiexes: eedb92abb9bb ("x86/mm: Make virtual memory layout dynamic
> > > > for CONFIG_X86_5LEVEL=y")
> > > > NEW: Fixes: eedb92abb9bb ("x86/mm: Make virtual memory layout dynamic
> > > > for CONFIG_X86_5LEVEL=y")
> > > >
> > > > Also, you can add...
> > > >
> > > > Cc: stable@xxxxxxxxxxxxxxx # v4.19+
> > > >
> > > > ...to catch the below.
> > > >
> > > > [ QUOTE ]
> > > > You can see that it was added in kernel 4.17-rc1, as above. Can we just
> > > > apply this patch to stable trees after 4.17?
> > >
> > > Oops, I just noticed this mail today, sorry.
> > >
> > > Boris has picked it into tip/x86/urgent. It should be in linus's tree
> > > very soon. Appreciate your help anyway.
> > >
> > 
> > I have applied the patch set from [0] and booted into the new kernel.
> > 
> > But I have set...
> > 
> > CONFIG_PGTABLE_LEVELS=4
> > # CONFIG_X86_5LEVEL is not set
> > 
> > To test this I need CONFIG_X86_5LEVEL=y?
> > Best two kernels with and without your patch.
> 
> Yeah, with CONFIG_X86_5LEVEL=y.
> 
> In fact I didn't have chance to trigger the issue to reproduce, then
> apply this patch to fix. As you know, the machine with large memory is
> too few. This is a code bug, so I just run the level 4 kernel and level
> 5 kernel to test the basic functionality.
> 
> If you have machine owning RAM 64 TB, and it supports 5-level, you can
			     ~~~~ 
		            Here, I meant owning RAM larger than 64 TB

> build two kernels w and w/o this patch, it's easy to reproduce.
> 
> > 
> > - Sedat -
> > 
> > [0] https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/urgent&id=00e5a2bbcc31d5fea853f8daeba0f06c1c88c3ff
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/x86/x86_64/5level-paging.rst
> > 
> > > Thanks
> > > Baoquan
> > >
> > > >
> > > > >
> > > > > v5.1.4: Build OK!
> > > > > v5.0.18: Build OK!
> > > > > v4.19.45: Build OK!
> > > > [ /QUOTE ]
> > > >
> > > > I had an early patchset of you tested (which included this one IIRC),
> > > > so feel free to add my...
> > > >
> > > >    Tested-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
> > > >
> > > > Hope this lands in tip or linux-stable Git.
> > > >
> > > > Thanks.
> > > >
> > > > Regards,
> > > > - Sedat -
> > > >
> > > > [1] https://lore.kernel.org/patchwork/patch/1077557/



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux