Hi On Thu, Dec 19, 2013 at 5:36 PM, Ingo Molnar <mingo@xxxxxxxxxx> wrote: > > * David Herrmann <dh.herrmann@xxxxxxxxx> wrote: > >> --- a/drivers/video/fbmem.c >> +++ b/drivers/video/fbmem.c >> @@ -35,6 +35,9 @@ >> >> #include <asm/fb.h> >> >> +#if IS_ENABLED(CONFIG_X86) >> +#include <asm/sysfb.h> >> +#endif > > I think this can be written as: > > #ifdef CONFIG_X86 > # include <asm/sysfb.h> > #endif > > also ... the dependency on a large, unrelated option like CONFIG_X86 > looks pretty ugly here - is there no other, more specific CONFIG_ > option that can be used here - such as CONFIG_FB_SIMPLE or > CONFIG_X86_SYSFB? > >> +#if IS_ENABLED(CONFIG_X86) >> + sysfb_unregister(apert, primary); >> +#endif > > Ditto. CONFIG_X86 is probably never 'm'.. will fix that. It was CONFIG_X86_SYSFB before and that works, too, but the broader X86 seemed more appropriate as sysfb is available on all x86. Note that I have patches here locally which move sysfb_register/unregister to drivers/video/sysfb.c and add include/linux/sysfb.h with dummies if CONFIG_SYSFB is not selected to avoid the #ifdef. This will allow other architectures to do gfx-hand-over, too. They seem too big for stable, though. That's why I split them up and added it to x86/kernel/sysfb.c first. Thanks David -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html