* David Herrmann <dh.herrmann@xxxxxxxxx> wrote: > --- a/drivers/video/fbmem.c > +++ b/drivers/video/fbmem.c > @@ -35,6 +35,9 @@ > > #include <asm/fb.h> > > +#if IS_ENABLED(CONFIG_X86) > +#include <asm/sysfb.h> > +#endif I think this can be written as: #ifdef CONFIG_X86 # include <asm/sysfb.h> #endif also ... the dependency on a large, unrelated option like CONFIG_X86 looks pretty ugly here - is there no other, more specific CONFIG_ option that can be used here - such as CONFIG_FB_SIMPLE or CONFIG_X86_SYSFB? > +#if IS_ENABLED(CONFIG_X86) > + sysfb_unregister(apert, primary); > +#endif Ditto. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html