Re: [PATCH] cifs: Always resolve hostname before reconnecting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 01, 2019 at 12:17:21PM -0800, Pavel Shilovsky wrote:
> пт, 1 февр. 2019 г. в 06:11, Sasha Levin <sashal@xxxxxxxxxx>:
> >
> > On Thu, Jan 31, 2019 at 10:37:54AM -0800, Pavel Shilovsky wrote:
> > >ср, 30 янв. 2019 г. в 23:16, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>:
> > >>
> > >> On Wed, Jan 30, 2019 at 04:07:30PM -0800, Pavel Shilovsky wrote:
> > >> > Commit 28eb24ff75c5 ("cifs: Always resolve hostname before reconnecting").
> > >> >
> > >> > In case a hostname resolves to a different IP address (e.g. long
> > >> > running mounts), make sure to resolve it every time prior to calling
> > >> > generic_ip_connect() in reconnect.
> > >> >
> > >> > This patch needs user space changes of cifs.upcall that set a timeout
> > >> > value for the "dns_resolver" key.
> > >> >
> > >> > Suggested-by: Steve French <stfrench@xxxxxxxxxxxxx>
> > >> > Signed-off-by: Paulo Alcantara <palcantara@xxxxxxx>
> > >> > Signed-off-by: Steve French <stfrench@xxxxxxxxxxxxx>
> > >> > Signed-off-by: Pavel Shilovsky <pshilov@xxxxxxxxxxxxx>
> > >> > ---
> > >> >  fs/cifs/connect.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >> >  1 file changed, 53 insertions(+)
> > >>
> > >> What stable kernel(s) is this to be applied to?
> > >>\
> > >
> > >All stable kernels that are under active maintenance may have the fix
> > >if it applies clearly. Please let me know if it doesn't.
> >
> > So this wasn't actually tested against any of the stable kernels? Why
> > not? Microsoft has a solid testsuite for it.
> 
> This was successfully tested on v4.4.y kernel.

That's odd, as you generated this diff against the 4.20.y kernel.

Oh well, I'll go queue this up, to all of the kernel trees, but be
careful...

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux