On Fri, Feb 01, 2019 at 12:50:27PM -0800, Jeff Kirsher wrote: > From: Anirudh Venkataramanan <anirudh.venkataramanan@xxxxxxxxx> > > This is a backport of the mainline commit b36c598c999c ("ice: > Updates to Tx scheduler code"). This change is required for the > driver to work with the latest firmware. Without this patch, > the driver fails probe. Note, this is a big change. You can't have these systems just run the old firmware? The fact that you require a kernel change for newer firmware, isn't the best, you don't provide backwards compatibility somehow? I'm all for adding new device ids and the like to stable kernels, but to backport new functionality just to get newer hardware to work on older kernels, is not the goal of the LTS kernel trees. Why can't you just have users use 4.20 or newer? There shouldn't be anything keeping them from doing that and just updating to the latest stable release every 4 months or so, right? thanks, greg k-h