Re: [PATCH 4.19 000/170] 4.19.14-stable review

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/8/19 2:43 PM, Breno Leitao wrote:
> That should be the case, I am wondering if this problem should be happening
> on upstream as well.

Fortunately this problem is not happening upstream because it has the  patch
below, which defines MSR_TM_ACTIVE(x) as 0, thus, the compiler does not look
for 'msr', which is undeclared when CONFIG_PPC_TRANSACTIONAL_MEM is not set.

Anyway, I do *not* think we should cherry pick this patch at stable. The
problem should be really fixed upstream (with a upcoming patch) and then
cherry-picked in stable.

commit 5c784c8414fba11b62e12439f11e109fb5751f38
Author: Breno Leitao <leitao@xxxxxxxxxx>
Date:   Thu Aug 16 14:21:07 2018 -0300

    powerpc/tm: Remove msr_tm_active()

    Currently msr_tm_active() is a wrapper around MSR_TM_ACTIVE() if
    CONFIG_PPC_TRANSACTIONAL_MEM is set, or it is just a function that
    returns false if CONFIG_PPC_TRANSACTIONAL_MEM is not set.

    This function is not necessary, since MSR_TM_ACTIVE() just do the same and
    could be used, removing the dualism and simplifying the code.

    This patchset remove every instance of msr_tm_active() and replaced it
    by MSR_TM_ACTIVE().

    Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>
    Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux