Re: [PATCH 4.19 000/170] 4.19.14-stable review

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hi Christoph

On 1/8/19 2:30 PM, Christoph Biedl wrote:
> Greg Kroah-Hartman wrote...
> 
>> -rc2 is out to fix some build issues:
>>  	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.14-rc2.gz
> 
> Eventually I gave it a try as well, and encountered a problem when
> building for ppc64 (big endian):
> 
> |   CC      arch/powerpc/net/bpf_jit_comp64.o
> | In file included from ./arch/powerpc/include/asm/processor.h:13,
> |                  from ./arch/powerpc/include/asm/book3s/64/mmu-hash.h:26,
> |                  from ./arch/powerpc/include/asm/book3s/64/mmu.h:30,
> |                  from ./arch/powerpc/include/asm/mmu.h:313,
> |                  from ./arch/powerpc/include/asm/lppaca.h:36,
> |                  from ./arch/powerpc/include/asm/paca.h:21,
> |                  from ./arch/powerpc/include/asm/current.h:16,
> |                  from ./include/linux/sched.h:12,
> |                  from arch/powerpc/kernel/signal_64.c:15:
> | arch/powerpc/kernel/signal_64.c: In function 'sys_rt_sigreturn':
> | arch/powerpc/kernel/signal_64.c:761:21: error: 'msr' undeclared (first use in this function)
> |   if (!MSR_TM_ACTIVE(msr)) {
> |                      ^~~
> | ./arch/powerpc/include/asm/reg.h:121:29: note: in definition of macro 'MSR_TM_ACTIVE'
> |  #define MSR_TM_ACTIVE(x) (((x) & MSR_TS_MASK) != 0) /* Transaction active? */
> |                              ^
> | arch/powerpc/kernel/signal_64.c:761:21: note: each undeclared identifier is reported only once for each function it appears in
> |   if (!MSR_TM_ACTIVE(msr)) {
> |                      ^~~
> | ./arch/powerpc/include/asm/reg.h:121:29: note: in definition of macro 'MSR_TM_ACTIVE'
> |  #define MSR_TM_ACTIVE(x) (((x) & MSR_TS_MASK) != 0) /* Transaction active? */
> |                              ^
> | make[4]: *** [scripts/Makefile.build:303: arch/powerpc/kernel/signal_64.o] Error 1
> | make[3]: *** [Makefile:1052: arch/powerpc/kernel] Error 2
> 
> Most likely this was introduced by (Cc'ed)
> 
> | commit 31d30f00e798eb3f18726a58c31f3edacd6f590d
> | Author: Breno Leitao <leitao@xxxxxxxxxx>
> | Date:   Wed Nov 21 17:21:09 2018 -0200
> |
> |     powerpc/tm: Set MSR[TS] just prior to recheckpoint
> 
> FWIW, CONFIG_PPC_TRANSACTIONAL_MEM is not set but perhaps should, will
> do more checks later.

That should be the case, I am wondering if this problem should be happening
on upstream as well.

Anyway, I will send a patch soon to get this fixed.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux