On Tue, Nov 06, 2018 at 04:30:44PM +0000, Russell King - ARM Linux wrote: > With any missing ENDPROC(), the only way to currently detect it is by > trying to run the code path - building alone does not flag any warnings > or errors. That's because the assembler has no idea whether what is > being assembled is code or data, and the purpose of ENDPROC() is to > mark it as code for the rest of the toolchain, so that it can apply the > bit 0 "fixup" for Thumb2 code. > So, in this case, the only way the error is detectable is to have a > platform where we boot a kernel which makes use of the HVC fixup path. > If that's too much to ask, then we're just going to have to accept that > Thumb2 kernels are going to be more fragile than ARM kernels because > there's no way to be certain that we have the correct annotations > everywhere - so we're going to have to rely on users reporting these > bugs _after_ the changes have hit mainline. Oh, totally - but currently none of the automated stuff is even trying to boot it so if we can do literally anything we'll be better off in terms of coverage even though it doesn't address the fundemental fragility.
Attachment:
signature.asc
Description: PGP signature
