On Tue, Nov 06, 2018 at 10:55:00AM +0000, Russell King - ARM Linux wrote: > On Tue, Nov 06, 2018 at 10:40:33AM +0000, Marc Zyngier wrote: > > As pointed out by Ard a while ago [1], this breaks Thumb-2 kernels. > > Please keep this series on hold until this is fixed in mainline and > > you can cherry-pick the corresponding patch. > You have to wonder at the effectiveness of the autobooters if stuff > like this is not caught. There's way too many configuration > combinations and firmwares for individuals to be able to test every > code path, we need autobooters to have sufficient diversity (and to > pick up on failures better) to be able to exercise these in an > automated fashion and report decent, reliable results. Right, and it depends on what people are willing to contribute hardware wise. However in the case of Thumb it's just a config option so we should probably ensure that there's at least one config that's at least getting booted, we could put something in the kernel source but I'm thinking that the easiest thing would be to teach at least KernelCI to just add a multi_v7+THUMB2 build (and then there's userspace too!). I'll try look into that after Plumbers, I've got some other stuff queued up there anyway. > It's taken from May to November to find this, which is _way_ too long > a timeframe. > The Thumb annotations for functions are always going to be very > troublesome as there's no automated way to validate them except by > actually exercising the code. There's some work going on on adding runtime testing which will help a bit there as it'll improve coverage but it's never going to exercise everything.
Attachment:
signature.asc
Description: PGP signature
