Re: [PATCH v2] mtd: rawnand: make subop helpers return unsigned values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > > A report from Colin Ian King pointed a CoverityScan issue where error
> > > > values on these helpers where not checked in the drivers. These
> > > > helpers can error out only in case of a software bug in driver code,
> > > > not because of a runtime/hardware error. Hence, let's WARN_ON() in this
> > > > case and return 0 which is harmless anyway.
> > > > 
> > > > Fixes: 8878b126df76 ("mtd: nand: add ->exec_op() implementation")
> > > > Cc: stable@xxxxxxxxxxxxxxx      
> > > 
> > > Is it really worth backporting this patch? I mean, the bug does not
> > > exist, it's just a potential problem that can only arise when
> > > drivers/core are buggy, which AFAICT is not the case yet :-).    
> > 
> > Ok, I'll remove the Cc: stable tag but I guess I can keep the Fixes
> > one.  
> 
> Sure.

Applied to nand/next without the cc:stable tag.
 

-- 
Miquel Raynal, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux