On Thu, 19 Jul 2018 00:42:58 +0200 Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: > Hi Boris, > > Boris Brezillon <boris.brezillon@xxxxxxxxxxx> wrote on Thu, 19 Jul 2018 > 00:31:34 +0200: > > > On Thu, 19 Jul 2018 00:09:12 +0200 > > Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: > > > > > A report from Colin Ian King pointed a CoverityScan issue where error > > > values on these helpers where not checked in the drivers. These > > > helpers can error out only in case of a software bug in driver code, > > > not because of a runtime/hardware error. Hence, let's WARN_ON() in this > > > case and return 0 which is harmless anyway. > > > > > > Fixes: 8878b126df76 ("mtd: nand: add ->exec_op() implementation") > > > Cc: stable@xxxxxxxxxxxxxxx > > > > Is it really worth backporting this patch? I mean, the bug does not > > exist, it's just a potential problem that can only arise when > > drivers/core are buggy, which AFAICT is not the case yet :-). > > Ok, I'll remove the Cc: stable tag but I guess I can keep the Fixes > one. Sure.