On Wed, Jul 18, 2018 at 12:55:46PM +0200, Greg KH wrote: > On Wed, Jul 18, 2018 at 11:47:18AM +0100, Mark Brown wrote: > > On Tue, Jul 17, 2018 at 01:49:15PM +0530, Amit Pundir wrote: > > > The bcm63xx SPI controller does not allow manual control of the CS > > > lines and will toggle it automatically before and after sending data, > > > so we are limited to messages that fit in the FIFO buffer. Since the CS > > > lines aren't available as GPIOs either, we will need to make slave > > > drivers aware of this limitation so they can handle them accordingly. > > This seems a bit new featureish... > It is? Reads like a bugfix to me to get crappy hardware to work > properly :) > Almost like a quirk addition. Yes, it is a quirk addition. > Anyway, it's a 9 line patch that the users of the hardware require to > get it to work, is it a problem to add? It's one of these cases where if someone notices the change it's because it causes the consumer driver to exercise code paths that they weren't otherwise exercising (for a little used feature too). If it were just in the driver perhaps but the actual use of the change would be in other code which makes it more risky.
Attachment:
signature.asc
Description: PGP signature
