Re: [PATCH for-4.9.y 2/5] spi/bcm63xx: make spi subsystem aware of message size limits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 18, 2018 at 11:47:18AM +0100, Mark Brown wrote:
> On Tue, Jul 17, 2018 at 01:49:15PM +0530, Amit Pundir wrote:
> > From: Jonas Gorski <jonas.gorski@xxxxxxxxx>
> > 
> > commit 0135c03df914f0481c61f097c78d37cece84f330 upstream.
> > 
> > The bcm63xx SPI controller does not allow manual control of the CS
> > lines and will toggle it automatically before and after sending data,
> > so we are limited to messages that fit in the FIFO buffer. Since the CS
> > lines aren't available as GPIOs either, we will need to make slave
> > drivers aware of this limitation so they can handle them accordingly.
> 
> This seems a bit new featureish...

It is?  Reads like a bugfix to me to get crappy hardware to work
properly :)

Almost like a quirk addition.

Anyway, it's a 9 line patch that the users of the hardware require to
get it to work, is it a problem to add?

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux