Hi Brian,
[...]
> @@ -1137,14 +1135,10 @@ static int m25p_probe(struct spi_device *spi)
> static int m25p_remove(struct spi_device *spi)
> {
> struct m25p *flash = spi_get_drvdata(spi);
> - int status;
>
> /* Clean up MTD stuff. */
> - status = mtd_device_unregister(&flash->mtd);
> - if (status == 0) {
> - kfree(flash->command);
> - kfree(flash);
> - }
> + mtd_device_unregister(&flash->mtd);
> +
> return 0;
> }
I wonder if we shouldn't return "status" in here in case mtd_device_unregister()
failed.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html