On Fri, Apr 06, 2018 at 11:21:28AM +0200, Thomas Petazzoni wrote: > Hello, > > On Wed, 4 Apr 2018 12:28:43 +0100, Lorenzo Pieralisi wrote: > > On Thu, Mar 29, 2018 at 10:39:41AM +0200, Thomas Petazzoni wrote: > > > In other to mimic other PCIe host controller drivers, introduce an > > > advk_pcie_valid_device() helper, used in the configuration read/write > > > functions. > > > > > > This patch by itself is not a fix, but it is required for a follow-up > > > patch that is a fix, hence the Fixes tag and the Cc to stable. > > > > Should not we just reshuffle patch 1 and 2 instead of sending this > > patch to stable ? I appreciate the merge window is open and timing is > > quite tight, it is just to avoid sending churn to stable kernels > > for not much. > > I can certainly do that, but it's actually Bjorn who asked in the first > place to introduce the advk_pcie_valid_device() helper. I did suggest [1] adding advk_pcie_valid_device() to match other drivers, but I don't care about the order of these patches. If it makes more sense to put the fix first for easier backporting to stable, that's fine with me. [1] https://lkml.kernel.org/r/20180110011136.GB157182@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx