On Thu, Oct 10, 2013 at 05:56:51AM +0900, Tetsuo Handa wrote:
> Greg Kroah-Hartman wrote:
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@xxxxxxxxxxxxxxx> know about it.
>
> It seems to me that this patch does not fit for 3.{0,4,10}-stable because
> sub_info->path != NULL check already exists in call_usermodehelper_exec().
I was thinking that, but the changelog suggested otherwise. Clarity on
this would be greatly appreciated.
> > --- a/kernel/kmod.c
> > +++ b/kernel/kmod.c
> > @@ -568,6 +568,10 @@ int call_usermodehelper_exec(struct subp
> > DECLARE_COMPLETION_ONSTACK(done);
> > int retval = 0;
> >
> > + if (!sub_info->path) {
> > + call_usermodehelper_freeinfo(sub_info);
> > + return -EINVAL;
> > + }
> > helper_lock();
> > if (!sub_info->path) {
>
> We should check whether this patch actually fixes the problem in 3.{0,4,10}.
> RHEL kernels would want to check for NULL at do_coredump().
Can you do that?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html