Re: Patch "kernel/kmod.c: check for NULL in call_usermodehelper_exec()" has been added to the 3.10-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greg Kroah-Hartman wrote:
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@xxxxxxxxxxxxxxx> know about it.

It seems to me that this patch does not fit for 3.{0,4,10}-stable because
sub_info->path != NULL check already exists in call_usermodehelper_exec().

> --- a/kernel/kmod.c
> +++ b/kernel/kmod.c
> @@ -568,6 +568,10 @@ int call_usermodehelper_exec(struct subp
>  	DECLARE_COMPLETION_ONSTACK(done);
>  	int retval = 0;
>  
> +	if (!sub_info->path) {
> +		call_usermodehelper_freeinfo(sub_info);
> +		return -EINVAL;
> +	}
>  	helper_lock();
>  	if (!sub_info->path) {

We should check whether this patch actually fixes the problem in 3.{0,4,10}.
RHEL kernels would want to check for NULL at do_coredump().

>  		retval = -EINVAL;
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]