On 01/18/18 00:44, Holger Hoffstätte wrote: > On 01/18/18 00:07, Andrew Morton wrote: >> On Wed, 17 Jan 2018 11:02:12 +0100 <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: >> >>> >>> This is a note to let you know that I've just added the patch titled >>> >>> tools/objtool/Makefile: don't assume sync-check.sh is executable >>> >>> to the 4.14-stable tree which can be found at: >>> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary >>> >>> The filename of the patch is: >>> tools-objtool-makefile-don-t-assume-sync-check.sh-is-executable.patch >>> and it can be found in the queue-4.14 subdirectory. >>> >>> If you, or anyone else, feels it should not be added to the stable tree, >>> please let <stable@xxxxxxxxxxxxxxx> know about it. >>> >>> >>> >From 0f908ccbeca99ddf0ad60afa710e72aded4a5ea7 Mon Sep 17 00:00:00 2001 >>> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >>> Date: Fri, 12 Jan 2018 16:53:17 -0800 >>> Subject: tools/objtool/Makefile: don't assume sync-check.sh is executable >>> >>> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >>> >>> commit 0f908ccbeca99ddf0ad60afa710e72aded4a5ea7 upstream. >>> >>> patch(1) loses the x bit. So if a user follows our patching >>> instructions in Documentation/admin-guide/README.rst, their kernel will >>> not compile. >>> >>> Fixes: 3bd51c5a371de ("objtool: Move kernel headers/code sync check to a script") >>> Reported-by: Nicolas Bock <nicolasbock@xxxxxxxxxx> >>> Reported-by Joakim Tjernlund <Joakim.Tjernlund@xxxxxxxxxxxx> >>> Cc: Ingo Molnar <mingo@xxxxxxxxxx> >>> Cc: Josh Poimboeuf <jpoimboe@xxxxxxxxxx> >>> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >>> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> >>> Cc: Holger Hoffstätte <holger@xxxxxxxxxxxxxxxxxxxxxx> >>> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> >> I'm curious. 3bd51c5a371de wasn't marked for any -stable so why is its >> fix being merged? > > Because some people/distributions/tools download a kernel-4.14 base > image and apply a patchset to create the final version (less to download). > Using patch to assemble the final version loses the x bit and voila: > build error. This patch removes the need for the executable bit, > and everyone is happy again. Argh..I just realized that I explained the wrong question, sorry. I guess the move was done simply so that any (inevitable) future patches apply more easily. -h