Re: [PATCH] X.509: fix comparisons of ->pkey_algo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] X.509: fix comparisons of ->pkey_algo
From: David Howells <dhowells@xxxxxxxxxx>
Date: Tue, 28 Nov 2017 10:57:54 +0000
Cc: dhowells@xxxxxxxxxx, keyrings@xxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, Alexander Potapenko <glider@xxxxxxxxxx>, Eric Biggers <ebiggers@xxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
In-reply-to: <20171127071724.25874-1-ebiggers3@gmail.com>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Eric Biggers <ebiggers3@xxxxxxxxx> wrote:

> if (strcmp(x509->pub->pkey_algo, sinfo->sig->pkey_algo))

Can you make this strcmp(...) != 0?  I know it may seem picky, but checking
strcmp() in this way kind of inverts the true/false thing.

Thanks,
David

References:
- [PATCH] X.509: fix comparisons of ->pkey_algo
  - From: Eric Biggers

Prev by Date: [PATCH 4.14 188/193] iwlwifi: mvm: support version 7 of the SCAN_REQ_UMAC FW command
Next by Date: [PATCH 4.14 187/193] iwlwifi: fix PCI IDs and configuration mapping for 9000 series
Previous by thread: Re: [PATCH] X.509: fix comparisons of ->pkey_algo
Next by thread: Apply "x86/mm: fix use-after-free of vma during userfaultfd fault" to 4.9-stable
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Development Newbies] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite Hiking] [Linux Kernel] [Linux SCSI]