Re: [PATCH] X.509: fix comparisons of ->pkey_algo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 26 Nov 2017, Eric Biggers wrote:

> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> ->pkey_algo used to be an enum, but was changed to a string by commit
> 4e8ae72a75aa ("X.509: Make algo identifiers text instead of enum").  But
> two comparisons were not updated.  Fix them to use strcmp().
> 
> This bug broke signature verification in certain configurations,
> depending on whether the string constants were deduplicated or not.
> 
> Fixes: 4e8ae72a75aa ("X.509: Make algo identifiers text instead of enum")
> Cc: <stable@xxxxxxxxxxxxxxx> # v4.6+
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> ---
>  crypto/asymmetric_keys/pkcs7_verify.c    | 2 +-
>  crypto/asymmetric_keys/x509_public_key.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)


Reviewed-by: James Morris <james.l.morris@xxxxxxxxxx>

-- 
James Morris
<james.l.morris@xxxxxxxxxx>




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]