On Wed, Oct 04, 2017 at 10:01:26AM -0700, Stefano Stabellini wrote: > On Wed, 4 Oct 2017, Arnd Bergmann wrote: > > xen_swiotlb_dma_mmap was backported from v4.10, but older > > kernels before commit 00085f1efa38 ("dma-mapping: use unsigned long > > for dma_attrs") use a different signature: > > > > arm/xen/mm.c:202:10: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] > > .mmap = xen_swiotlb_dma_mmap, > > ^~~~~~~~~~~~~~~~~~~~ > > arm/xen/mm.c:202:10: note: (near initialization for 'xen_swiotlb_dma_ops.mmap') > > > > This adapts the patch to the old calling conventions. > > > > Fixes: 2f0b82b1b830 ("swiotlb-xen: implement xen_swiotlb_dma_mmap callback") > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx> Thanks, I've added this tag to the patch. greg k-h