Re: [PATCH v3 1/7] KEYS: don't let add_key() update an uninstantiated key

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3 1/7] KEYS: don't let add_key() update an uninstantiated key
From: David Howells <dhowells@xxxxxxxxxx>
Date: Wed, 04 Oct 2017 15:34:30 +0100
Cc: dhowells@xxxxxxxxxx, keyrings@xxxxxxxxxxxxxxx, Michael Halcrow <mhalcrow@xxxxxxxxxx>, linux-security-module@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Eric Biggers <ebiggers@xxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B7A777EAAB
In-reply-to: <20170927195047.122358-2-ebiggers3@gmail.com>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Eric Biggers <ebiggers3@xxxxxxxxx> wrote:

> +	if ((key->flags & ((1 << KEY_FLAG_INVALIDATED) |
> +			   (1 << KEY_FLAG_REVOKED) |
> +			   (1 << KEY_FLAG_INSTANTIATED))) !=
> +	    (1 << KEY_FLAG_INSTANTIATED)) {

Does this need READ_ONCE(), I wonder?

David

References:
- [PATCH v3 1/7] KEYS: don't let add_key() update an uninstantiated key
  - From: Eric Biggers

Prev by Date: [stable backport] stable-4.4 warning with gcc-7
Next by Date: Patch "fix xen_swiotlb_dma_mmap prototype" has been added to the 3.18-stable tree
Previous by thread: [PATCH v3 1/7] KEYS: don't let add_key() update an uninstantiated key
Next by thread: Re: [PATCH v3 1/7] KEYS: don't let add_key() update an uninstantiated key
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Development Newbies] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite Hiking] [Linux Kernel] [Linux SCSI]