Re: WTF: patch "[PATCH] mmc: dw_mmc: Use device_property_read instead of" was seriously submitted to be applied to the 4.12-stable tree?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ping? Greg, I see that you released 4.12.4/4.9.40 without these patches, but
not having heard back from you, I wondered if my reply below was lost and we
were both waiting on each other.  Thanks!

On 7/25/2017 11:55 AM, Chris Metcalf wrote:
On 7/25/2017 10:48 AM, Greg KH wrote:
On Mon, Jul 24, 2017 at 09:22:44PM -0400, Chris Metcalf wrote:
On 7/24/2017 7:32 PM, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
The patch below was submitted to be applied to the 4.12-stable tree.

I fail to see how this patch meets the stable kernel rules as found at
Documentation/process/stable_kernel_rules.rst.

[...]

Using the device_property interfaces allows the dw_mmc driver to work
on platforms which run on either device tree or ACPI.

Signed-off-by: David Woods <dwoods@xxxxxxxxxxxx>
Reviewed-by: Chris Metcalf <cmetcalf@xxxxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxx
Acked-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
I encouraged Dave to cc stable, so this is on me if it was a bad call.

This bug is the only thing blocking our ARM64 hardware (Mellanox
BlueField, google if curious) from booting up with RedHat 7 on our
standard hardware config with an eMMC rootfs.  RedHat 7 requires
ACPI for server configuration builds, and the eMMC drivers didn't
support ACPI, just device tree, so the chip couldn't boot.

The two changes are obviously correct (mechanical substitution
of "of_*" to "device_*"), short, and fix a clear bug in booting up RHEL.
Now obviously we are working with RedHat directly to get them to
include the fix (RH bugzilla 1466917) but it seemed plausible to
push the fix upstream so it would get picked up elsewhere as well and
enable booting older mainstream ARM64 kernels on our hardware.
So is this the _only_ change that is needed to get a 4.9 and/or a 4.12
kernel running on your hardware?  Or would they need other ones as well?

As far as we know, these are the only patches needed to get RHEL booted.
There are additional drivers for new IP on our SoC, but those are
orthogonal to actually booting up the system.

For the 4.9 backport you may want to also just take e44bb0cbdc88
("device property: Make dev_fwnode() public") or else just open-code
the place in the patch where dev_fwnode() is used.


--
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]