On 7/24/2017 7:32 PM, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
The patch below was submitted to be applied to the 4.12-stable tree. I fail to see how this patch meets the stable kernel rules as found at Documentation/process/stable_kernel_rules.rst. [...] Using the device_property interfaces allows the dw_mmc driver to work on platforms which run on either device tree or ACPI. Signed-off-by: David Woods <dwoods@xxxxxxxxxxxx> Reviewed-by: Chris Metcalf <cmetcalf@xxxxxxxxxxxx> Cc: stable@xxxxxxxxxxxxxx Acked-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
I encouraged Dave to cc stable, so this is on me if it was a bad call. This bug is the only thing blocking our ARM64 hardware (Mellanox BlueField, google if curious) from booting up with RedHat 7 on our standard hardware config with an eMMC rootfs. RedHat 7 requires ACPI for server configuration builds, and the eMMC drivers didn't support ACPI, just device tree, so the chip couldn't boot. The two changes are obviously correct (mechanical substitution of "of_*" to "device_*"), short, and fix a clear bug in booting up RHEL. Now obviously we are working with RedHat directly to get them to include the fix (RH bugzilla 1466917) but it seemed plausible to push the fix upstream so it would get picked up elsewhere as well and enable booting older mainstream ARM64 kernels on our hardware. Thanks! -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com