Re: [PATCH] iio: proximity: as3935: fix AS3935_INT mask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 27, 2017 at 12:59 AM, Matt Ranostay
<matt.ranostay@xxxxxxxxxxxx> wrote:
> On Thu, Apr 27, 2017 at 12:52 AM, Matt Ranostay
> <matt.ranostay@xxxxxxxxxxxx> wrote:
>> AS3935 interrupt mask has been incorrect so valid lightning events
>> would never trigger an buffer event. Also noise interrupt should be
>> BIT(0).
>
> Er, BIT(1)

Gah zero re-read the line wrong. Datasheet fun!
>
> Damn comment errors :)
>
>>
>> Fixes: 24ddb0e4bba4 ("iio: Add AS3935 lightning sensor support")
>> CC: stable@xxxxxxxxxxxxxxx
>> Signed-off-by: Matt Ranostay <matt.ranostay@xxxxxxxxxxxx>
>> ---
>>  drivers/iio/proximity/as3935.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c
>> index aa0d0be1a608..8f081ef4802d 100644
>> --- a/drivers/iio/proximity/as3935.c
>> +++ b/drivers/iio/proximity/as3935.c
>> @@ -40,9 +40,9 @@
>>  #define AS3935_AFE_PWR_BIT     BIT(0)
>>
>>  #define AS3935_INT             0x03
>> -#define AS3935_INT_MASK                0x07
>> +#define AS3935_INT_MASK                0x0f
>>  #define AS3935_EVENT_INT       BIT(3)
>> -#define AS3935_NOISE_INT       BIT(1)
>> +#define AS3935_NOISE_INT       BIT(0)
>>
>>  #define AS3935_DATA            0x07
>>  #define AS3935_DATA_MASK       0x3F
>> --
>> 2.11.0
>>



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]