On Wed, Apr 5, 2017 at 10:01 AM, kernelci.org bot <bot@xxxxxxxxxxxx> wrote:
>
> stable/linux-3.16.y build: 204 builds: 7 failed, 197 passed, 159 errors, 251 warnings (v3.16.43)
Hi Ben,
The numbers look worse than before, but this seems to be mostly because of
additional configs getting enabled in kernelci. I suspect that last
time kernelci
gave up after it saw too many errors in the initial builds, but this
time it appears
to have built all the ones it normally does (without warnings in 4.1.y+)
The majority of the warnings and errors from the previous test are now gone.
Going through the remaining warnings, I've found some of the fixes that
I missed the first time around and should have most of the ones that came up in
this build from the new configs.
Some of the commit IDs are from v4.1.y or v4.4.y instead of upstream,
sorry about
the mixup.
> allmodconfig+CONFIG_OF=n (x86) — PASS, 0 errors, 73 warnings, 0 section mismatches
I think I missed all the x86 allmodconfig ones last time
> Warnings:
> arch/x86/include/asm/pgtable_64.h:184:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
This was introduced in 4428f3bdd8fe8 (in v4.9), the backport of 082d5b6b60e9
("mm/hugetlb: check for reserved hugepages during memory offline").
eb03aa00856100 (also in v4.9) has the side-effect of addressing the warning
but did not get backported into v3.16.
4.1.y-stable and 4.4.y-stable contain neither of the two patches.
> drivers/ata/pata_hpt366.c:376:9: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
> drivers/ata/pata_hpt366.c:379:9: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
> drivers/ata/pata_hpt366.c:382:9: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
6ec0a86c645b ata: hpt366: fix constant cast warning
> sound/pci/oxygen/oxygen_mixer.c:91:43: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
8ec7cfce376 ALSA: oxygen: Fix logical-not-parentheses warning
> sound/soc/codecs/adau1977.c:971:20: warning: large integer implicitly truncated to unsigned type [-Woverflow]
d8df26bb57d ASoC: adau1977: Fix truncation warning on 64 bit architectures
> drivers/gpio/gpio-sch311x.c:286:3: warning: ignoring return value of 'gpiochip_remove', declared with attribute warn_unused_result [-Wunused-result]
9f5132ae82fd gpio: remove all usage of gpio_remove retval in driver/gpio
> net/netfilter/nft_compat.c:298:9: warning: switch condition has boolean value [-Wswitch-bool]
> net/netfilter/nft_ct.c:49:2: warning: enumeration value 'NFT_CT_DIRECTION' not handled in switch [-Wswitch]
> net/netfilter/nft_ct.c:49:2: warning: enumeration value 'NFT_CT_STATUS' not handled in switch [-Wswitch]
> net/netfilter/nft_ct.c:49:2: warning: enumeration value 'NFT_CT_MARK' not handled in switch [-Wswitch]
c1f86676777 netfilter: Fix switch statement warnings with recent gcc.
> sound/soc/fsl/fsl_sai.c:337:7: warning: large integer implicitly truncated to unsigned type [-Woverflow]
af96ff5b7448 ASoC: fsl_sai: Set SYNC bit of TCR2 to Asynchronous Mode
> sound/soc/fsl/imx-audmux.c:70:13: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> sound/soc/fsl/imx-audmux.c:162:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
e5f89768e9b ASoC: imx-audmux: Use uintptr_t for port numbers
> drivers/iio/industrialio-core.c:408:23: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long int' [-Wformat=]
introduced by d91d35de32 ("iio:core: fix IIO_VAL_FRACTIONAL sign handling")
that apparently was backported incorrectly into v3.18.y.
> drivers/message/i2o/i2o_config.c:893:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> drivers/message/i2o/i2o_config.c:953:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
The driver is obsolete and was removed in v4.2. It looks like the warning should
still be there in v4.1.y, but I don't remember having seen it. It
would be trivial
to fix this with an obvious patch adding a cast.
> drivers/spi/spi-atmel.c:1022:13: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> drivers/spi/spi-atmel.c:1257:19: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
67f08d690aa90e spi/atmel: Fix pointer to int conversion warnings on 64
bit builds
> drivers/net/ethernet/amd/nmclan_cs.c:624:3: warning: 'pcmcia_request_exclusive_irq' is deprecated [-Wdeprecated-declarations]
5f5316fcd08ef7 am2150: Update nmclan_cs.c to use update PCMCIA API
96a30175f927f net: am2150: fix nmclan_cs.c shared interrupt handling
> drivers/staging/bcm/CmHost.c:1502:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> drivers/staging/bcm/CmHost.c:1545:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> drivers/staging/bcm/CmHost.c:1563:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
The driver was removed in v3.19, but I could create a patch for the warning.
> drivers/scsi/be2iscsi/be_main.c:3156:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
dd29dae00d3 be2iscsi: Fix bogus WARN_ON length check
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c:836:1: warning: the frame size of 8192 bytes is larger than 2048 bytes [-Wframe-larger-than=]
e6c97234d1b18d i40e: Reduce stack in i40e_dbg_dump_desc
> drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not properly converted to the DMA API [-Wcpp]
The driver was properly converted in v4.2 and the warning removed, but the
conversion would be outside of stable-kernel-rules.
> arch/x86/include/asm/spinlock.h:99:3: warning: implicit declaration of function '__ticket_lock_spinning' [-Wimplicit-function-declaration]
> arch/x86/include/asm/spinlock.h:142:3: warning: implicit declaration of function '__ticket_unlock_kick' [-Wimplicit-function-declaration]
> arch/x86/include/asm/spinlock.h:99:3: warning: implicit declaration of function '__ticket_lock_spinning' [-Wimplicit-function-declaration]
> arch/x86/include/asm/spinlock.h:142:3: warning: implicit declaration of function '__ticket_unlock_kick' [-Wimplicit-function-declaration]
927392d73a97 x86/boot: Add CONFIG_PARAVIRT_SPINLOCKS quirk to
arch/x86/boot/compressed/misc.h
> Section mismatches:
> WARNING: arch/x86/kernel/built-in.o(.text.unlikely+0x1752): Section mismatch in reference from the function cpumask_empty.constprop.3() to the variable .init.data:nmi_ipi_mask
> WARNING: arch/x86/built-in.o(.text.unlikely+0x1a6a): Section mismatch in reference from the function cpumask_empty.constprop.3() to the variable .init.data:nmi_ipi_mask
> WARNING: vmlinux.o(.text.unlikely+0x1b31): Section mismatch in reference from the function cpumask_empty.constprop.3() to the variable .init.data:nmi_ipi_mask
f0ba662a6e06f2 x86: Properly _init-annotate NMI selftest code
> allnoconfig (mips) — PASS, 0 errors, 1 warning, 0 section mismatches
>
> Warnings:
> mm/page_alloc.c:5328:34: warning: array subscript is below array bounds [-Warray-bounds]
Still unsure what fixed this, haven't bisected it yet, but am
relatively sure it's a simple fix.
kernelci finds this on multiple mips configurations but none of the others, most
likely because we use gcc-6 for mips unlike the other architectures that are
on 4.8, 4.9 or 5
> ar7_defconfig (mips) — PASS, 0 errors, 3 warnings, 0 section mismatches
>
> Warnings:
> include/linux/kernel.h:719:17: warning: comparison of distinct pointer types lacks a cast
> drivers/net/ethernet/ti/cpmac.c:1229:2: warning: #warning FIXME: unhardcode gpio&reset bits [-Wcpp]
d43e6fb4ac4abfe4e cpmac: remove hopeless #warning
> bcm63xx_defconfig (mips) — PASS, 0 errors, 3 warnings, 0 section mismatches
>
> Warnings:
> arch/mips/kernel/bmips_vec.S:214: Warning: .previous without corresponding .section; ignored
> arch/mips/kernel/bmips_vec.S:290: Warning: .previous without corresponding .section; ignored
4ec8f9e9b08451 MIPS: BMIPS: Fix ".previous without corresponding
.section" warnings
> db1xxx_defconfig (mips) — PASS, 0 errors, 2 warnings, 0 section mismatches
>
> Warnings:
> drivers/scsi/scsi_tgt_if.c:289:36: warning: passing argument 1 of 'virt_to_phys' makes pointer from integer without a cast [-Wint-conversion]
removed in 3.17
> decstation_defconfig (mips) — PASS, 0 errors, 4 warnings, 0 section mismatches
>
> Warnings:
> arch/mips/dec/int-handler.S:149: Warning: macro instruction expanded into multiple instructions in a branch delay slot
> arch/mips/dec/int-handler.S:198: Warning: macro instruction expanded into multiple instructions in a branch delay slot
3021773c7c3e7 MIPS: DEC: Avoid la pseudo-instruction in delay slots
> defconfig (arm64) — PASS, 0 errors, 3 warnings, 0 section mismatches
>
> Warnings:
> ipc/sem.c:377:6: warning: '___p1' may be used uninitialized in this function [-Wmaybe-uninitialized]
> ipc/sem.c:377:6: warning: '___p1' may be used uninitialized in this function [-Wmaybe-uninitialized]
I'm guessing that it's
878a84d5a8a18a4a arm64: add missing data types in
smp_load_acquire/smp_store_release
It certainly can't hurt to backport this even if the problem is something else.
> efm32_defconfig (arm) — PASS, 0 errors, 2 warnings, 0 section mismatches
>
> Warnings:
> arch/arm/kernel/head-nommu.S:167: Warning: Use of r13 as a source register is deprecated when r15 is the destination register.
970d96f9a81b0dd ARM: 8383/1: nommu: avoid deprecated source register on mov
> include/linux/of.h:831:20: warning: comparison of distinct pointer types lacks a cast
8ce8ebeb572d70 clk/efm32gg: fix dt init prototype
> genmai_defconfig (arm) — PASS, 0 errors, 1 warning, 0 section mismatches
>
> Warnings:
> drivers/spi/spi-rspi.c:633:6: warning: unused variable 'ret' [-Wunused-variable]
95029a00886f0c8 spi: rspi: Remove unused variable in rspi_rz_transfer_one()
> imx_v6_v7_defconfig (arm) — PASS, 0 errors, 1 warning, 0 section mismatches
>
> Warnings:
> drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c:1450:8: warning: 'skb' may be used uninitialized in this function [-Wmaybe-uninitialized]
22f44150aad7a brcmfmac: avoid gcc-5.1 warning
You commented that you thought this was not a reliable fix, but empirical
evidence suggests that it's "good enough". The Wmaybe-uninitialized
warnings are by definition a bit of guesswork on the compiler's side
(this is a variation of the halting problem), so I think it's good enough
to do the same as the newer kernels that don't have the warning.
> ip27_defconfig (mips) — FAIL, 2 errors, 12 warnings, 0 section mismatches
>
> Errors:
> drivers/scsi/mpt2sas/mpt2sas_base.c:3550:1: error: insn does not satisfy its constraints:
> drivers/scsi/mpt2sas/mpt2sas_base.c:3550:1: internal compiler error: in extract_constrain_insn, at recog.c:2190
This is probably a variant of another bug I worked around in
b6176494683 MIPS: ip27: Disable qlge driver in defconfig
> Warnings:
> lib/cpumask.c:194:25: warning: the address of 'cpu_all_bits' will always evaluate as 'true' [-Waddress]
f36963c9d3f6f4 cpumask_set_cpu_local_first => cpumask_local_spread, lament
> include/linux/sched.h:1979:56: warning: 'noio_flag' may be used uninitialized in this function [-Wmaybe-uninitialized]
unclear
> drivers/tty/nozomi.c:857:9: warning: 'size' may be used uninitialized in this function [-Wmaybe-uninitialized]
a4f642a8a3c28 tty: nozomi: avoid a harmless gcc warning
> drivers/scsi/bfa/bfa_ioc.c:3665:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
> drivers/scsi/bfa/bfa_ioc.c:3673:4: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
b7f4d6343820af5 bfa: Fix indentation
> drivers/net/wireless/iwlegacy/3945.c:1022:5: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
682c360eb26f819 iwlegacy: avoid warning about missing braces
> drivers/net/ethernet/neterion/vxge/vxge-main.c:2150:13: warning: 'adaptive_coalesce_rx_interrupts' defined but not used [-Wunused-function]
> drivers/net/ethernet/neterion/vxge/vxge-main.c:2122:13: warning: 'adaptive_coalesce_tx_interrupts' defined but not used [-Wunused-function]
57e7c8cef224af166 net: vxge: avoid unused function warnings
> drivers/scsi/mvsas/mv_sas.c:736:3: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
7789cd39274c51 mvsas: fix misleading indentation
> ip28_defconfig (mips) — FAIL, 1 error, 0 warnings, 0 section mismatches
>
> Errors:
> arch/mips/sgi-ip22/Platform:29: *** gcc doesn't support needed option -mr10k-cache-barrier=store. Stop.
23ca9b522383d MIPS: ip22: Fix ip28 build for modern gcc
> jazz_defconfig (mips) — PASS, 0 errors, 6 warnings, 0 section mismatches
>
> Warnings:
> drivers/block/paride/pg.c:308:15: warning: comparison of constant '1' with boolean expression is always false [-Wbool-compare]
> drivers/block/paride/pg.c:344:14: warning: comparison of constant '1' with boolean expression is always false [-Wbool-compare]
> drivers/block/paride/pg.c:373:15: warning: comparison of constant '1' with boolean expression is always false [-Wbool-compare]
> drivers/block/paride/pg.c:540:28: warning: comparison of constant '1' with boolean expression is always false [-Wbool-compare]
946e879819425 paride: fix the "verbose" module param
> lemote2f_defconfig (mips) — FAIL, 1 error, 2 warnings, 0 section mismatches
>
> Errors:
> arch/mips/mm/fault.c:321:1: error: the frame size of 1104 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
unclear
> malta_defconfig (mips) — PASS, 0 errors, 3 warnings, 0 section mismatches
>
> Warnings:
> drivers/net/wireless/hostap/hostap_hw.c:842:5: warning: 'rec' may be used uninitialized in this function [-Wmaybe-uninitialized]
48dc5fb3ba53b2 hostap: avoid uninitialized variable use in hfa384x_get_rid
> msp71xx_defconfig (mips) — PASS, 0 errors, 3 warnings, 0 section mismatches
>
> Warnings:
> arch/mips/pci/ops-pmcmsp.c:196:24: warning: 'bpci_lock' defined but not used [-Wunused-variable]
c4a305374bbf36414 MIPS: MSP71xx: remove odd locking in PCI config
space access code
(yes, this is safe in 3.16 too)
> drivers/mtd/maps/pmcmsp-flash.c:149:30: warning: passing argument 1 of 'strncpy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
906b268477bc03d mtd: pmcmsp: use kstrndup instead of kmalloc+strncpy
> mtx1_defconfig (mips) — PASS, 0 errors, 3 warnings, 0 section mismatches
>
> Warnings:
> drivers/net/ethernet/dec/tulip/winbond-840.c:910:2: warning: #warning Processor architecture undefined [-Wcpp]
de92718883ddbcd net: tulip: turn compile-time warning into dev_warn()
> drivers/net/ethernet/dec/tulip/uli526x.c:1086:4: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
e1395a321eab1 drivers/net/ethernet/dec/tulip/uli526x.c: fix misleading
indentation in uli526x_timer
> multi_v5_defconfig (arm) — PASS, 0 errors, 4 warnings, 0 section mismatches
>
> Warnings:
> warning: (DRM_RADEON && DRM_NOUVEAU && DRM_I915 && DRM_GMA500 && DRM_SHMOBILE && DRM_TILCDC && FB_BACKLIGHT && FB_MX3 && USB_APPLEDISPLAY && FB_OLPC_DCON && ASUS_LAPTOP && SONY_LAPTOP && THINKPAD_ACPI && EEEPC_LAPTOP && ACPI_CMPC && SAMSUNG_Q10) selects BACKLIGHT_CLASS_DEVICE which has unmet direct dependencies (HAS_IOMEM && BACKLIGHT_LCD_SUPPORT)
9c8ee3c73413938 video: mx3fb: always enable BACKLIGHT_LCD_SUPPORT
> multi_v7_defconfig+CONFIG_THUMB2_KERNEL=y+CONFIG_ARM_MODULE_PLTS=y (arm) — FAIL, 122 errors, 2 warnings, 0 section mismatches
>
> Errors:
> /tmp/cclmqETn.s:29: Error: only SUBS PC, LR, #const allowed -- `sub pc,pc,#4'
> arch/arm/kernel/iwmmxt.S:76: Error: selected processor does not support Thumb mode `mrc p15,0,r2,c1,c0,2'
> arch/arm/kernel/iwmmxt.S:79: Error: cannot honor width suffix -- `tst r2,#0xf'
13d1b9575ac2c2d ARM: 8221/1: PJ4: allow building in Thumb-2 mode
> nlm_xlp_defconfig (mips) — FAIL, 1 error, 4 warnings, 0 section mismatches
> Warnings:
> net/rds/message.c:260:18: warning: passing argument 1 of 'virt_to_phys' makes pointer from integer without a cast [-Wint-conversion]
unclear
> fs/gfs2/dir.c:768:9: warning: 'leaf_no' may be used uninitialized in this function [-Wmaybe-uninitialized]
> fs/gfs2/dir.c:987:8: warning: 'leaf_no' may be used uninitialized in this function [-Wmaybe-uninitialized]
unclear
> omap1_defconfig (arm) — PASS, 0 errors, 4 warnings, 0 section mismatches
>
> Warnings:
> warning: (ARCH_OMAP1) selects ARCH_OMAP which has unmet direct dependencies (ARCH_MULTI_V6 || ARCH_MULTI_V7)
> warning: (ARCH_OMAP1) selects ARCH_OMAP which has unmet direct dependencies (ARCH_MULTI_V6 || ARCH_MULTI_V7)
> warning: (ARCH_OMAP1) selects ARCH_OMAP which has unmet direct dependencies (ARCH_MULTI_V6 || ARCH_MULTI_V7)
> warning: (ARCH_OMAP1) selects ARCH_OMAP which has unmet direct dependencies (ARCH_MULTI_V6 || ARCH_MULTI_V7)
52aaac5ae52ad9a ARM: OMAP: Fix Kconfig warning for omap1
> qi_lb60_defconfig (mips) — FAIL, 32 errors, 1 warning, 0 section mismatches
>
> Errors:
> arch/mips/jz4740/irq.h:20:39: error: 'struct irq_data' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> arch/mips/jz4740/irq.h:21:38: error: 'struct irq_data' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> include/linux/irqdesc.h:80:33: error: 'NR_IRQS' undeclared here (not in a function)
> arch/mips/jz4740/irq.h:20:39: error: 'struct irq_data' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> arch/mips/jz4740/irq.h:21:38: error: 'struct irq_data' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> arch/mips/jz4740/irq.c:49:39: error: 'JZ4740_IRQ_BASE' undeclared (first use in this function)
5b235dc2647e4 MIPS: Fix the build on jz4740 after removing the custom gpio.h
> rbtx49xx_defconfig (mips) — PASS, 0 errors, 3 warnings, 0 section mismatches
>
> Warnings:
> arch/mips/pci/ops-tx4927.c:202:16: warning: unused variable 'val' [-Wunused-variable]
1bc2d3e38e5b MIPS: TXx9: Delete an unused variable in tx4927_pcibios_setup
> drivers/mtd/maps/rbtx4939-flash.c:38:31: warning: unused variable 'pdata' [-Wunused-variable]
e4c4c9c15ebe8ec mtd: maps: rbtx4939-flash: delete an unused variable
in rbtx4939_flash_remove
> realview-smp_defconfig (arm) — PASS, 0 errors, 3 warnings, 0 section mismatches
>
> Warnings:
> arch/arm/mm/cache-l2x0.c:167:13: warning: 'l2x0_cache_sync' defined but not used [-Wunused-function]
> arch/arm/mm/cache-l2x0.c:184:13: warning: 'l2x0_flush_all' defined but not used [-Wunused-function]
> arch/arm/mm/cache-l2x0.c:194:13: warning: 'l2x0_disable' defined but not used [-Wunused-function]
20e783e39e55 ARM: 8296/1: cache-l2x0: clean up aurora cache handling
> rm200_defconfig (mips) — FAIL, 0 errors, 7 warnings, 0 section mismatches
>
> Warnings:
> drivers/scsi/aic94xx/aic94xx_sds.c:597:2: warning: 'offs' may be used uninitialized in this function [-Wmaybe-uninitialized]
36dd5acd196574d4 aic94xx: Skip reading user settings if flash is not found
> arch/mips/boot/elf2ecoff.c:270:8: warning: variable 'shstrtab' set but not used [-Wunused-but-set-variable]
2d76e9633b572ae MIPS: elf2ecoff: Fix warning due to dead code.
Arnd