On Mon, Apr 10, 2017 at 11:42:40AM -0500, Tom Lendacky wrote: > On 4/10/2017 11:06 AM, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > > > This is a note to let you know that I've just added the patch titled > > > > amd-xgbe: Prepare for working with more than one type of phy > > > > to the 4.9-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > The filename of the patch is: > > amd-xgbe-prepare-for-working-with-more-than-one-type-of-phy.patch > > and it can be found in the queue-4.9 subdirectory. > > > > If you, or anyone else, feels it should not be added to the stable tree, > > please let <stable@xxxxxxxxxxxxxxx> know about it. > > Hi Greg, > > I'm not sure why this is scheduled for stable... The support for > multiple phys was not added until 4.10 and so is not needed before > that. > > I missed the emails about the jumbo MTU processing patch for this driver > ("amd-xgbe: Fix jumbo MTU processing on newer hardware") going back to > 4.4-stable and 4.9-stable. That patch is only needed for newer hardware > which is supported only in 4.10 and later. If that is cause for pulling > this patch in, then it is best to revert the MTU patch rather than add > this one. Argh, you are right. Come on Sasha, a diffstat like: > > --- > > drivers/net/ethernet/amd/xgbe/Makefile | 3 > > drivers/net/ethernet/amd/xgbe/xgbe-dev.c | 58 - > > drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 6 > > drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c | 19 > > drivers/net/ethernet/amd/xgbe/xgbe-main.c | 214 ++----- > > drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 543 +++++------------ > > drivers/net/ethernet/amd/xgbe/xgbe-phy-v1.c | 821 +++++++++++++++++++++++++++ > > drivers/net/ethernet/amd/xgbe/xgbe.h | 130 ++-- > > 8 files changed, 1137 insertions(+), 657 deletions(-) > > create mode 100644 drivers/net/ethernet/amd/xgbe/xgbe-phy-v1.c that? Not ok for stable :( I'll go drop this, and here I thought I reviewed this patch series... greg k-h