Re: Linux 4.4.34

[Eric Dumazet <edumazet@xxxxxxxxxx>]

On Tue, Nov 22, 2016 at 9:55 AM, Andre Noll <maan@xxxxxxxxxxxxxxxx> wrote:
> On Tue, Nov 22, 09:46, Eric Dumazet wrote
>> This is an aliasing problem.
>> Tom code is hard to read and understand.
>>
>> Andre, could you try :
>>
>> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
>> index 69e4463a4b1b..b045980faaea 100644
>> --- a/net/core/flow_dissector.c
>> +++ b/net/core/flow_dissector.c
>> @@ -157,6 +157,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb,
>>                 memcpy(key_eth_addrs, &eth->h_dest, sizeof(*key_eth_addrs));
>>         }
>>
>> +       barrier();
>>  again:
>>         switch (proto) {
>>         case htons(ETH_P_IP): {
>
> This patch on top of v4.4.34 makes no difference: I'm still getting
> the panic in eth_type_trans().
>

What compiler are you using exactly ?

Please try :

diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 69e4463a4b1b..48791f372aa2 100644
--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c
@@ -551,6 +551,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb,

        key_control->thoff = (u16)nhoff;
 out:
+       barrier();
        key_basic->n_proto = proto;
        key_basic->ip_proto = ip_proto;
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html