Re: Linux 4.4.34

[Andre Noll <maan@xxxxxxxxxxxxxxxx>]

On Tue, Nov 22, 09:46, Eric Dumazet wrote
> This is an aliasing problem.
> Tom code is hard to read and understand.
> 
> Andre, could you try :
> 
> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
> index 69e4463a4b1b..b045980faaea 100644
> --- a/net/core/flow_dissector.c
> +++ b/net/core/flow_dissector.c
> @@ -157,6 +157,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb,
>                 memcpy(key_eth_addrs, &eth->h_dest, sizeof(*key_eth_addrs));
>         }
> 
> +       barrier();
>  again:
>         switch (proto) {
>         case htons(ETH_P_IP): {

This patch on top of v4.4.34 makes no difference: I'm still getting
the panic in eth_type_trans().

Andre
-- 
Max Planck Institute for Developmental Biology
Spemannstraße 35, 72076 Tübingen, Germany. Phone: (+49) 7071 601 829
http://people.tuebingen.mpg.de/maan/

Attachment: signature.asc
Description: Digital signature