Re: [added to the 4.1 stable tree] um: Don't discard .text.exit section

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alexander,

On 01.09.2016 18:14, Levin, Alexander wrote:
> From: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
> 
> This patch has been added to the 4.1 stable tree. If you have any
> objections, please let us know.

why is this queued for 4.1?
The Fixes-Tag clearly states that the issue was introduced in 4.7.

Thanks,
//richard

> ===============
> 
> [ Upstream commit dad2232844073295c64e9cc2d734a0ade043e0f6 ]
> 
> Commit e41f501d3912 ("vmlinux.lds: account for destructor sections")
> added '.text.exit' to EXIT_TEXT which is discarded at link time by default.
> This breaks compilation of UML:
>      `.text.exit' referenced in section `.fini_array' of
>      /usr/lib/gcc/x86_64-linux-gnu/6/../../../x86_64-linux-gnu/libc.a(sdlerror.o):
>      defined in discarded section `.text.exit' of
>      /usr/lib/gcc/x86_64-linux-gnu/6/../../../x86_64-linux-gnu/libc.a(sdlerror.o)
> 
> Apparently UML doesn't want to discard exit text, so let's place all EXIT_TEXT
> sections in .exit.text.
> 
> Fixes: e41f501d3912 ("vmlinux.lds: account for destructor sections")
> Reported-by: Stefan Traby <stefan@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx>
> Acked-by: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
> ---
>  arch/um/include/asm/common.lds.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/um/include/asm/common.lds.S b/arch/um/include/asm/common.lds.S
> index 1dd5bd8..1330553 100644
> --- a/arch/um/include/asm/common.lds.S
> +++ b/arch/um/include/asm/common.lds.S
> @@ -81,7 +81,7 @@
>    .altinstr_replacement : { *(.altinstr_replacement) }
>    /* .exit.text is discard at runtime, not link time, to deal with references
>       from .altinstructions and .eh_frame */
> -  .exit.text : { *(.exit.text) }
> +  .exit.text : { EXIT_TEXT }
>    .exit.data : { *(.exit.data) }
>  
>    .preinit_array : {
> 
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]