Re: [patch added to the 3.12 stable tree] mmc: sdhci-esdhc: Make 8BIT bus work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/10/2015, 05:27 PM, Joakim Tjernlund wrote:
> On Mon, 2015-08-10 at 16:17 +0200, Jiri Slaby wrote:
>> From: Joakim Tjernlund <Joakim.Tjernlund@xxxxxxxxxxxx>
>>
>> This patch has been added to the 3.12 stable tree. If you have any
>> objections, please let us know.
> 
> I think 8BIT support was added after 3.12 and if so I do not think this
> is appropriate for 3.12

It's in 3.12 already:
$ git describe --exact-match --contains 66b50a00992d
v3.11-rc1~50^2~5

But 3.10 does not need the patch. 3.10.86 was released with that though.
Is it worth reverting or can it cause any havoc to the system?

>> ===============
>>
>> commit 8e91125ff3f57f15c6568e2a6d32743b3f7815e4 upstream.
>>
>> Support for 8BIT bus with was added some time ago to sdhci-esdhc but
>> then missed to remove the 8BIT from the reserved bit mask which made
>> 8BIT non functional.
>>
>> Fixes: 66b50a00992d ("mmc: esdhc: Add support for 8-bit bus width and..")
>> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@xxxxxxxxxxxx>
>> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
>> ---
>>  drivers/mmc/host/sdhci-esdhc.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-esdhc.h b/drivers/mmc/host/sdhci-esdhc.h
>> index a2a06420e463..ebff71092743 100644
>> --- a/drivers/mmc/host/sdhci-esdhc.h
>> +++ b/drivers/mmc/host/sdhci-esdhc.h
>> @@ -47,7 +47,7 @@
>>  #define ESDHC_DMA_SYSCTL	0x40c
>>  #define ESDHC_DMA_SNOOP		0x00000040
>>  
>> -#define ESDHC_HOST_CONTROL_RES	0x05
>> +#define ESDHC_HOST_CONTROL_RES	0x01
>>  
>>  static inline void esdhc_set_clock(struct sdhci_host *host, unsigned int clock,
>>  				   unsigned int host_clock)

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]