On Mon, May 13, 2013 at 06:58:34PM +1100, Tomoya MORINAGA wrote:
> pdc_desc_get() is called from pd_prep_slave_sg, and the function is
> called from interrupt context(e.g. Uart driver "pch_uart.c").
> In fact, I saw kernel error message.
> So, GFP_ATOMIC must be used not GFP_NOIO.
>
> commitID:5c1ef59168c485318e40ba485c1eba57d81d0faa
> Kernel: 3.0 3.2 3.4 3.9
Thanks, I'm queuing it for the 3.5 kernel as well.
Cheers,
--
Luis
>
> Cc: stable@xxxxxxxxxxxxxxx Signed-off-by: Tomoya MORINAGA
> <tomoya.rohm@xxxxxxxxx> Signed-off-by: Vinod Koul
> <vinod.koul@xxxxxxxxx> --- drivers/dma/pch_dma.c | 2 +- 1 file
> changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> index d01faeb..ce3dc3e 100644
> --- a/drivers/dma/pch_dma.c
> +++ b/drivers/dma/pch_dma.c
> @@ -476,7 +476,7 @@ static struct pch_dma_desc *pdc_desc_get(struct pch_dma_chan *pd_chan)
> dev_dbg(chan2dev(&pd_chan->chan), "scanned %d descriptors\n", i);
>
> if (!ret) {
> - ret = pdc_alloc_desc(&pd_chan->chan, GFP_NOIO);
> + ret = pdc_alloc_desc(&pd_chan->chan, GFP_ATOMIC);
> if (ret) {
> spin_lock(&pd_chan->lock);
> pd_chan->descs_allocated++;
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html