Re: [PATCH 3.9-stable] drivers/rtc/rtc-pcf2123.c: fix error return code in pcf2123_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 01, 2013 at 10:54:39AM +0900, Jonghwan Choi wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> 
> This patch looks like it should be in the 3.8-stable tree, should we apply
> it?

I believe this is applicable to the other stable trees.  I'm queuing
it for the 3.5 kernel.

Cheers,
--
Luis


> 
> ------------------
> 
> From: "Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>"
> 
> commit 35623715818dfa720cccf99cd280dcbb4b78da23 upstream
> 
> Fix to return -ENODEV in the chip not found error handling
> case instead of 0, as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> Cc: Jingoo Han <jg1.han@xxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jonghwan Choi <jhbird.choi@xxxxxxxxxxx>
> ---
>  drivers/rtc/rtc-pcf2123.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c
> index 02b742a..6dd6b38 100644
> --- a/drivers/rtc/rtc-pcf2123.c
> +++ b/drivers/rtc/rtc-pcf2123.c
> @@ -265,6 +265,7 @@ static int pcf2123_probe(struct spi_device *spi)
>  
>  	if (!(rxbuf[0] & 0x20)) {
>  		dev_err(&spi->dev, "chip not found\n");
> +		ret = -ENODEV;
>  		goto kfree_exit;
>  	}
>  
> -- 
> 1.8.1.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]