Re: [PATCH] Btrfs: cleanup orphan reservation if truncate fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 08, 2013 at 01:48:35PM -0500, Josef Bacik wrote:
> commit 4a7d0f6854c4a4ad1dba00a3b128a32d39b9a742 upstream
> 
> I noticed we were getting lots of warnings with xfstest 83 because we have
> reservations outstanding.  This is because we moved the orphan add outside
> of the truncate, but we don't actually cleanup our reservation if something
> fails.  This fixes the problem and I no longer see warnings.  Thanks,

Thanks, I'm queuing it for the 3.5 tree.

Cheers,
--
Luis

> 
> Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx> --- fs/btrfs/inode.c
> | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index cf26778..1692580 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -2538,6 +2538,8 @@ int btrfs_orphan_cleanup(struct btrfs_root *root)
>  				goto out;
>  
>  			ret = btrfs_truncate(inode);
> +			if (ret)
> +				btrfs_orphan_del(NULL, inode);
>  		} else {
>  			nr_unlink++;
>  		}
> -- 
> 1.7.7.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]