Re: [PATCH] Btrfs: account for orphan inodes properly during cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 08, 2013 at 03:52:13PM -0500, Josef Bacik wrote:
> On Fri, Mar 08, 2013 at 12:18:40PM -0700, Greg KH wrote:
> > On Fri, Mar 08, 2013 at 01:47:47PM -0500, Josef Bacik wrote:
> > > commit 925396ecf251432d6d0f703a6cfd0cb9e651d936 upstream
> > > 
> > > Dave sent me a panic where we were doing the orphan cleanup and panic'ed
> > > trying to release our reservation from the orphan block rsv.  The reason for
> > > this is because our orphan block rsv had been free'd out from underneath us
> > > because the transaction commit found that there were no orphan inodes
> > > according to its count and decided to free it.  This is incorrect so make
> > > sure we inc the orphan inodes count so the accounting is all done properly.
> > > This would also cause the warning in the orphan commit code normally if you
> > > had any orphans to cleanup as they would only decrement the orphan count so
> > > you'd get a negative orphan count which could cause problems during runtime.
> > > Thanks,
> > > 
> > > Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>
> > 
> > What kernel version(s) do you want this applied to?  Same for the other
> > btrfs patch you sent us.
> > 
> 
> Sorry I realized I forgot to put that as soon as I sent them, this one needs to
> go in everything, it's an oldy but a goody.  The other patch is just for 3.8.
> Thanks,

Thanks, I'm queuing it for 3.5 tree.

Cheers,
--
Luis
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]