From: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
commit 16a6d2e685e8f9a2f51dd5a363d3f97fcad35e22 upstream.
The device_for_each_child_node() loop requires calls to
fwnode_handle_put() upon early returns to decrement the refcount of
the child node and avoid leaking memory if that error path is triggered.
There is one early returns within that loop in
intel_platform_pinctrl_prepare_community(), but fwnode_handle_put() is
missing.
Instead of adding the missing call, the scoped version of the loop can
be used to simplify the code and avoid mistakes in the future if new
early returns are added, as the child node is only used for parsing, and
it is never assigned.
Cc: stable@xxxxxxxxxxxxxxx
Fixes: c5860e4a2737 ("pinctrl: intel: Add a generic Intel pin control platform driver")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/pinctrl/intel/pinctrl-intel-platform.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/pinctrl/intel/pinctrl-intel-platform.c
+++ b/drivers/pinctrl/intel/pinctrl-intel-platform.c
@@ -90,7 +90,6 @@ static int intel_platform_pinctrl_prepar
struct intel_community *community,
struct intel_platform_pins *pins)
{
- struct fwnode_handle *child;
struct intel_padgroup *gpps;
unsigned int group;
size_t ngpps;
@@ -131,7 +130,7 @@ static int intel_platform_pinctrl_prepar
return -ENOMEM;
group = 0;
- device_for_each_child_node(dev, child) {
+ device_for_each_child_node_scoped(dev, child) {
struct intel_padgroup *gpp = &gpps[group];
gpp->reg_num = group;
Patches currently in stable-queue which might be from javier.carrasco.cruz@xxxxxxxxx are
queue-6.11/iio-amplifiers-ada4250-add-missing-select-regmap_spi-in-kconfig.patch
queue-6.11/iio-pressure-bm1390-add-missing-select-iio_-triggered_-buffer-in-kconfig.patch
queue-6.11/iio-accel-kx022a-add-missing-select-iio_-triggered_-buffer-in-kconfig.patch
queue-6.11/pinctrl-intel-platform-fix-error-path-in-device_for_each_child_node.patch
queue-6.11/iio-chemical-ens160-add-missing-select-iio_-triggered_-buffer-in-kconfig.patch
queue-6.11/iio-light-veml6030-fix-iio-device-retrieval-from-embedded-device.patch
queue-6.11/iio-adc-ti-lmp92064-add-missing-select-regmap_spi-in-kconfig.patch
queue-6.11/iio-frequency-adf4377-add-missing-select-remap_spi-in-kconfig.patch
queue-6.11/iio-proximity-mb1232-add-missing-select-iio_-triggered_-buffer-in-kconfig.patch
queue-6.11/iio-magnetometer-af8133j-add-missing-select-iio_-triggered_-buffer-in-kconfig.patch
queue-6.11/iio-resolver-ad2s1210-add-missing-select-regmap-in-kconfig.patch
queue-6.11/iio-adc-ti-lmp92064-add-missing-select-iio_-triggered_-buffer-in-kconfig.patch
queue-6.11/iio-dac-ad5770r-add-missing-select-regmap_spi-in-kconfig.patch
queue-6.11/iio-adc-ti-ads124s08-add-missing-select-iio_-triggered_-buffer-in-kconfig.patch
queue-6.11/iio-dac-ad5766-add-missing-select-iio_-triggered_-buffer-in-kconfig.patch
queue-6.11/iio-dac-ltc1660-add-missing-select-regmap_spi-in-kconfig.patch
queue-6.11/iio-dac-stm32-dac-core-add-missing-select-regmap_mmio-in-kconfig.patch
queue-6.11/iio-resolver-ad2s1210-add-missing-select-triggered_-buffer-in-kconfig.patch
queue-6.11/iio-adc-ad7944-add-missing-select-iio_-triggered_-buffer-in-kconfig.patch
queue-6.11/iio-adc-ti-ads8688-add-missing-select-iio_-triggered_-buffer-in-kconfig.patch
queue-6.11/iio-light-bu27008-add-missing-select-iio_-triggered_-buffer-in-kconfig.patch
queue-6.11/iio-light-veml6030-fix-als-sensor-resolution.patch
queue-6.11/iio-dac-ad3552r-add-missing-select-iio_-triggered_-buffer-in-kconfig.patch
