This is a note to let you know that I've just added the patch titled
rsi: Remove unnecessary boolean condition
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
rsi-remove-unnecessary-boolean-condition.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From f613e4803dd6d1f41a86f6406d4c994fa3d387a0 Mon Sep 17 00:00:00 2001
From: Nathan Chancellor <natechancellor@xxxxxxxxx>
Date: Fri, 21 Sep 2018 02:48:29 -0700
Subject: rsi: Remove unnecessary boolean condition
From: Nathan Chancellor <natechancellor@xxxxxxxxx>
commit f613e4803dd6d1f41a86f6406d4c994fa3d387a0 upstream.
Clang warns that the address of a pointer will always evaluated as true
in a boolean context.
drivers/net/wireless/rsi/rsi_91x_mac80211.c:927:50: warning: address of
array 'key->key' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (vif->type == NL80211_IFTYPE_STATION && key->key &&
~~ ~~~~~^~~
1 warning generated.
Link: https://github.com/ClangBuiltLinux/linux/issues/136
Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/net/wireless/rsi/rsi_91x_mac80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
@@ -924,7 +924,7 @@ static int rsi_hal_key_config(struct iee
if (status)
return status;
- if (vif->type == NL80211_IFTYPE_STATION && key->key &&
+ if (vif->type == NL80211_IFTYPE_STATION &&
(key->cipher == WLAN_CIPHER_SUITE_WEP104 ||
key->cipher == WLAN_CIPHER_SUITE_WEP40)) {
if (!rsi_send_block_unblock_frame(adapter->priv, false))
Patches currently in stable-queue which might be from natechancellor@xxxxxxxxx are
queue-4.19/rsi-remove-unnecessary-boolean-condition.patch
queue-4.19/hwmon-scmi-remove-redundant-pointer-check.patch
queue-4.19/kernel-extable.c-use-address-of-operator-on-section-symbols.patch
queue-4.19/regulator-da905-2-5-remove-unnecessary-array-check.patch
queue-4.19/lib-dynamic_debug.c-use-address-of-operator-on-section-symbols.patch
