This is a note to let you know that I've just added the patch titled wifi: rtlwifi: remove always-true condition pointed out by GCC 12 to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: wifi-rtlwifi-remove-always-true-condition-pointed-out-by-gcc-12.patch and it can be found in the queue-4.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From ee3db469dd317e82f57b13aa3bc61be5cb60c2b4 Mon Sep 17 00:00:00 2001 From: Jakub Kicinski <kuba@xxxxxxxxxx> Date: Fri, 20 May 2022 12:43:15 -0700 Subject: wifi: rtlwifi: remove always-true condition pointed out by GCC 12 From: Jakub Kicinski <kuba@xxxxxxxxxx> commit ee3db469dd317e82f57b13aa3bc61be5cb60c2b4 upstream. The .value is a two-dim array, not a pointer. struct iqk_matrix_regs { bool iqk_done; long value[1][IQK_MATRIX_REG_NUM]; }; Acked-by: Kalle Valo <kvalo@xxxxxxxxxx> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c @@ -2414,10 +2414,7 @@ void rtl92d_phy_reload_iqk_setting(struc RT_TRACE(rtlpriv, COMP_SCAN, DBG_LOUD, "Just Read IQK Matrix reg for channel:%d....\n", channel); - if ((rtlphy->iqk_matrix[indexforchannel]. - value[0] != NULL) - /*&&(regea4 != 0) */) - _rtl92d_phy_patha_fill_iqk_matrix(hw, true, + _rtl92d_phy_patha_fill_iqk_matrix(hw, true, rtlphy->iqk_matrix[ indexforchannel].value, 0, (rtlphy->iqk_matrix[ Patches currently in stable-queue which might be from kuba@xxxxxxxxxx are queue-4.19/tcp-return-user_mss-for-tcp_maxseg-in-close-listen-s.patch queue-4.19/net-sched-sch_ingress-only-create-under-tc_h_ingress.patch queue-4.19/af_packet-do-not-use-read_once-in-packet_bind.patch queue-4.19/af_packet-fix-data-races-of-pkt_sk-sk-num.patch queue-4.19/net-usb-qmi_wwan-set-dtr-quirk-for-broadmobi-bm818.patch queue-4.19/atm-hide-unused-procfs-functions.patch queue-4.19/net-sched-sch_clsact-only-create-under-tc_h_clsact.patch queue-4.19/net-sched-prohibit-regrafting-ingress-or-clsact-qdis.patch queue-4.19/net-netlink-fix-netlink_list_memberships-length-repo.patch queue-4.19/tcp-deny-tcp_disconnect-when-threads-are-waiting.patch queue-4.19/netrom-fix-info-leak-in-nr_write_internal.patch queue-4.19/wifi-rtlwifi-remove-always-true-condition-pointed-out-by-gcc-12.patch queue-4.19/net-sched-fix-null-pointer-dereference-in-mq_attach.patch queue-4.19/net-sched-reserve-tc_h_ingress-tc_h_clsact-for-ingre.patch queue-4.19/net-cdc_ncm-deal-with-too-low-values-of-dwntboutmaxs.patch